Skip to content

fix v0.9.2 : lookup online status for connections table#1422

Merged
klesh merged 1 commit into
release-v0.9from
jc-1409-integrations-table-online-status
Mar 31, 2022
Merged

fix v0.9.2 : lookup online status for connections table#1422
klesh merged 1 commit into
release-v0.9from
jc-1409-integrations-table-online-status

Conversation

@e2corporation
Copy link
Copy Markdown
Contributor

@e2corporation e2corporation commented Mar 29, 2022

v0.9.2 Config-UI / Data Integrations / Connections "ONLINE" Status

  • Update ConnectionManager Hook
    • Extend testConnection with manual Payload Support
    • Add testAllConnections function to maintain tested connections list
  • Update Data Connections Table Online Column
  • Test Data Integrations

Description

[V0.9.0 RELEASE TARGET] release-v0.9

This PR fixes the "Online" status column indicator for a Data Connection record on all Data Provider Tables. Previously the indicator would assume online based on a 200 Response from the API sources endpoint, which is not very meaningful. Now a connection Test is performed with the saved parameters for a data source after all the connections are fetched.

The default state would be "Offline" (status=0) for a connection, once a test is completed it will be updated to "Online" (status=1) or sometimes "Failed" (status=2) based on the TestResponse results.

ℹ️ NOTE: This hotfix will also be cherry-picked and applied to the main branch under a separate Pull Request to maintain consistency.

Does this close any open issues?

#1409

Screenshots

Screen Shot 2022-03-29 at 1 21 05 PM

Screen Shot 2022-03-29 at 6 04 06 PM

@e2corporation e2corporation added pr-type/bug-fix This PR fixes a bug component/config-ui This issue or PR relates to config-ui labels Mar 29, 2022
@e2corporation e2corporation self-assigned this Mar 29, 2022
@e2corporation e2corporation changed the title v0.9.2 fix: lookup online status for connections table fix v0.9.2 : lookup online status for connections table Mar 29, 2022
@e2corporation e2corporation requested a review from klesh March 30, 2022 13:32
@e2corporation e2corporation marked this pull request as ready for review March 30, 2022 13:33
Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit bd4de19 into release-v0.9 Mar 31, 2022
@klesh klesh deleted the jc-1409-integrations-table-online-status branch March 31, 2022 05:29
@klesh klesh added the cherrypick This PR is cherry-picked from another branch label Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick This PR is cherry-picked from another branch component/config-ui This issue or PR relates to config-ui pr-type/bug-fix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

config ui - "online" status is not accurate for data integrations table

2 participants