Skip to content

fix(github): fix minor bug#1430

Merged
klesh merged 1 commit into
release-v0.9from
fix-github-pr-commit-converter
Mar 31, 2022
Merged

fix(github): fix minor bug#1430
klesh merged 1 commit into
release-v0.9from
fix-github-pr-commit-converter

Conversation

@warren830
Copy link
Copy Markdown
Contributor

@warren830 warren830 commented Mar 31, 2022

Summary

fix wrong usage of prId in github_pull_request_commit_converter

Key Points

  • This is a breaking change
  • New or existing documentation is updated

Description

Describe what this PR does, and aims to solve in a few sentences.

Does this close any open issues?

Closes #1426

Screenshots

first run
image
second run
image

Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh force-pushed the fix-github-pr-commit-converter branch from 1fd84c2 to 08d1cbd Compare March 31, 2022 05:32
@klesh klesh merged commit d198bb9 into release-v0.9 Mar 31, 2022
@klesh klesh deleted the fix-github-pr-commit-converter branch March 31, 2022 05:32
@warren830 warren830 added the pr-type/bug-fix This PR fixes a bug label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-type/bug-fix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants