Skip to content

refactor: gitextractor performance improvement #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klesh merged 1 commit into from
Mar 31, 2022
Merged

refactor: gitextractor performance improvement #1435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions plugins/gitextractor/parser/libgit2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,38 +156,38 @@ func (l *LibGit2) run(ctx context.Context, repo *git.Repository, repoId string)
if err != nil {
continue
}
commitFile := new(code.CommitFile)
err = diff.ForEach(func(file git.DiffDelta, progress float64) (
git.DiffForEachHunkCallback, error) {
if commitFile.CommitSha != "" {
err = l.store.CommitFiles(commitFile)
if err != nil {
logger.Error("CommitFiles error:", err)
}
}
commitFile.CommitSha = id.String()
commitFile.FilePath = file.NewFile.Path
return func(hunk git.DiffHunk) (git.DiffForEachLineCallback, error) {
return func(line git.DiffLine) error {
if line.Origin == git.DiffLineAddition {
commitFile.Additions += line.NumLines
}
if line.Origin == git.DiffLineDeletion {
commitFile.Deletions += line.NumLines
}
return nil
}, nil
}, nil
}, git.DiffDetailLines)
if err != nil {
return err
}
if commitFile.CommitSha != "" {
err = l.store.CommitFiles(commitFile)
if err != nil {
logger.Error("CommitFiles error:", err)
}
}
//commitFile := new(code.CommitFile)
//err = diff.ForEach(func(file git.DiffDelta, progress float64) (
// git.DiffForEachHunkCallback, error) {
// if commitFile.CommitSha != "" {
// err = l.store.CommitFiles(commitFile)
// if err != nil {
// logger.Error("CommitFiles error:", err)
// }
// }
// commitFile.CommitSha = id.String()
// commitFile.FilePath = file.NewFile.Path
// return func(hunk git.DiffHunk) (git.DiffForEachLineCallback, error) {
// return func(line git.DiffLine) error {
// if line.Origin == git.DiffLineAddition {
// commitFile.Additions += line.NumLines
// }
// if line.Origin == git.DiffLineDeletion {
// commitFile.Deletions += line.NumLines
// }
// return nil
// }, nil
// }, nil
//}, git.DiffDetailLines)
//if err != nil {
// return err
//}
//if commitFile.CommitSha != "" {
// err = l.store.CommitFiles(commitFile)
// if err != nil {
// logger.Error("CommitFiles error:", err)
// }
//}
stats, err := diff.Stats()
if err != nil {
continue
Expand Down