Skip to content

Refactor helper to replace GetDb with GetDal#2184

Merged
klesh merged 7 commits into
apache:mainfrom
merico-ai:kw-2183-helper-dal
Jun 14, 2022
Merged

Refactor helper to replace GetDb with GetDal#2184
klesh merged 7 commits into
apache:mainfrom
merico-ai:kw-2183-helper-dal

Conversation

@klesh
Copy link
Copy Markdown
Contributor

@klesh klesh commented Jun 14, 2022

Summary

  1. Refactor helper to replace GetDb with GetDal
  2. Update godoc
  3. Removed OnNewBatchSave and let BatchSaveDivider handle it to simplify the logic

Does this close any open issues?

Closes #2183

Copy link
Copy Markdown
Contributor

@warren830 warren830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh force-pushed the kw-2183-helper-dal branch from 375512d to ed104db Compare June 14, 2022 07:55
@klesh klesh merged commit af3b9b7 into apache:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor helper to use GetDal instead of deprecated GetDb

2 participants