[feat-2433]: record execution time for plugin subtasks#2455
Merged
Conversation
b369053 to
bffe805
Compare
klesh
reviewed
Jul 12, 2022
2efcd5a to
51bf84a
Compare
Contributor
Author
keon94
commented
Jul 13, 2022
| "time" | ||
| ) | ||
|
|
||
| // Subtask_07112022 DB snapshot model of models.Subtask |
Contributor
Author
There was a problem hiding this comment.
@klesh is this still the correct way of managing migrations? I see recently there was a big refactor and everything is using init_schema.go now as opposed to individual migrations
Contributor
There was a problem hiding this comment.
We added MultiConnection for all other plugins in v0.12. With this connection table added, every single table of the plugin was affected, as well as the Domain Layer tables, we have to flush the no-longer-valid data to maintain the data integrity, So, might as well drop existing migration scripts and rebuild the tables.
However, the Framework migration should be not affected, we should keep the migration scripts as it was, with that said, you are doing the right thing.
3e31aa6 to
b0b7f46
Compare
klesh
reviewed
Jul 21, 2022
3a2cae2 to
3b61ec4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

label(bug, feature etc.)Summary
Does this close any open issues?
#2433
Screenshots
included below.
Other Information
Any other information that is important to this PR.