feat(github): collect comments/reviews#2484
Merged
Conversation
warren830
added
pr-type/feature-development
warren830
force-pushed
the
2452-featuregithub-get-all-normal-comments-review-review-comments-and-store-it-in-tablepull_request_comments
branch
from
384df48 to
8e122bf
Compare
keon94
reviewed
Jul 13, 2022
|
|
||
| func (*initSchemas) Version() uint64 { | ||
| return 20220707232344 | ||
| return 20220711232344 |
Contributor
There was a problem hiding this comment.
Isn't this going to cause this migration to be ran again and therefore drop all existing tables via Up()? Wouldn't that cause data loss?
Contributor
Author
There was a problem hiding this comment.
Yes, this will cause data loss
warren830
force-pushed
the
2452-featuregithub-get-all-normal-comments-review-review-comments-and-store-it-in-tablepull_request_comments
branch
10 times, most recently
from
840fecd to
3a63db2
Compare
warren830
force-pushed
the
2452-featuregithub-get-all-normal-comments-review-review-comments-and-store-it-in-tablepull_request_comments
branch
3 times, most recently
from
deedf33 to
f31e9b4
Compare
warren830
force-pushed
the
2452-featuregithub-get-all-normal-comments-review-review-comments-and-store-it-in-tablepull_request_comments
branch
from
f31e9b4 to
b8097ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Does this close any open issues?
closes #2452
Screenshots
_tool_github_pull_request_comments
_tool_github_pull_request_reviews
pull_request_comments
Other Information
Any other information that is important to this PR.