Skip to content

docs: fixed two 404 links.#2488

Merged
klesh merged 3 commits into
apache:mainfrom
Pranshu-Raj:Changed-two-links
Jul 14, 2022
Merged

docs: fixed two 404 links.#2488
klesh merged 3 commits into
apache:mainfrom
Pranshu-Raj:Changed-two-links

Conversation

@Pranshu-Raj
Copy link
Copy Markdown
Contributor

@Pranshu-Raj Pranshu-Raj commented Jul 13, 2022

-Deploy in Temporal Mode(Changed the URL)
-Deploy in Developer Mode(Changed the URL)

⚠️   Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation & PR Template
  • This PR is using a label (bug, feature etc.)
  • My code is has necessary documentation (if appropriate)
  • I have added any relevant tests
  • This section (⚠️   Pre Checklist) will be removed when submitting PR

Summary

Does this close any open issues?

Please mention the issues here.

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

-Deploy in Temporal Mode(Changed the URL)
-Deploy in Developer Mode(Changed the URL)
@warren830
Copy link
Copy Markdown
Contributor

@Pranshu-Raj Seems like your commit msg has some problems. Please check it. You can refer to https://devlake.apache.org/community/make-contribution/development-workflow#style-guides

@Pranshu-Raj Pranshu-Raj changed the title Fixed two 404 links. docs:fixed two 404 links. Jul 13, 2022
@Pranshu-Raj
Copy link
Copy Markdown
Contributor Author

i have fixed the commit-msg issue.

@warren830
Copy link
Copy Markdown
Contributor

i have fixed the commit-msg issue.

I see there is still one more issue, can you insert a space after docs:

@Pranshu-Raj Pranshu-Raj changed the title docs:fixed two 404 links. docs: fixed two 404 links. Jul 14, 2022
@Pranshu-Raj
Copy link
Copy Markdown
Contributor Author

I think now it's good 🥺

@likyh
Copy link
Copy Markdown
Contributor

likyh commented Jul 14, 2022

Hmmm, You need to change the commit message.
git rebase -i [commit hash]
after changing it, git push -f to push it。

But this time, we can merge it. 😁

@klesh
Copy link
Copy Markdown
Contributor

klesh commented Jul 14, 2022

@Pranshu-Raj Hi, I think the only thing you need to do is to modify the commit message by running git commit --amend, and then git push --force to update the PR.

@likyh
Copy link
Copy Markdown
Contributor

likyh commented Jul 14, 2022

@Pranshu-Raj Hi, I think the only thing you need to do is to modify the commit message by running git commit --amend, and then git push --force to update the PR.

It merged the main branch. so git commit --amend cannot work

Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit 3214b67 into apache:main Jul 14, 2022
@klesh
Copy link
Copy Markdown
Contributor

klesh commented Jul 14, 2022

Never mind, I've modified the squashed commit, it should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants