perf: added error handling missing code #2562
Conversation
|
|
| if err != nil { | ||
| return nil,err | ||
| } | ||
| return &core.ApiResourceOutput{Body: connection},nil |
There was a problem hiding this comment.
please keep in line with other plugins, and missing space.
There was a problem hiding this comment.
okay that i did previously but why this lint commit-msg test is failing can u help me with that?
There was a problem hiding this comment.
both 165 and 167 need to add space, you added the space at 167 and missing 165, it maybe lint commit-msg test is failing.
There was a problem hiding this comment.
try running make fmt. the go formatter should take care of these kind of things
There was a problem hiding this comment.
seems like this is the only issue left for this PR, do you plan to work on it? @Pranshu-Raj
There was a problem hiding this comment.
sorry @klesh I am unable to resolve this issue.
There was a problem hiding this comment.
No problem. I will try to fix the rest
Added the error handling in GetConnection
added the error handling in GetConnection
added the error handling GetConnection
added the error handling GetConnection
edited the err handling err to nil
changed err to nil
5 participants
label(bug, feature etc.)Summary
Added error handling missing code in gitlab/api/connections.go (GET /plugins/gitlab/connections/:connectionId)
Added error handling missing code in gitlab/jenkins/connections.go (GET /plugins/jenkins/connections/:connectionId)
Added error handling missing code in gitlab/jira/connections.go (GET /plugins/jira/connections/:connectionId)
Added error handling missing code in gitlab/tapd/connections.go (GET /plugins/tapd/connections/:connectionId)
Does this close any open issues?
[Refactor][gitlab,jira,jenkins,tapd] Missing error handling #2561
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.