Skip to content

feat config-ui: blueprint settings management (edit blueprint)#2659

Merged
klesh merged 25 commits into
apache:mainfrom
merico-ai:jc-2615-blueprint-settings
Aug 17, 2022
Merged

feat config-ui: blueprint settings management (edit blueprint)#2659
klesh merged 25 commits into
apache:mainfrom
merico-ai:jc-2615-blueprint-settings

Conversation

@e2corporation
Copy link
Copy Markdown
Contributor

@e2corporation e2corporation commented Aug 2, 2022

📦 Config-UI / Blueprints / Blueprint Settings (Edit Blueprint)

  • Feature Blueprint Settings (Edit a Blueprint)
    • Apply reference UX Layout for Settings UI
    • CSS & Styling Updates
    • Edit Blueprint Name
    • Edit Sync Frequency
    • Edit Data Scopes (Multi-step)
      • GitHub
      • GitLab
      • Jenkins
      • TAPD(TAPD CN Instance not available)
      • JIRA
    • Edit Advanced JSON
  • Create Data Scopes Manager Hook
  • Update Blueprint Manager Hook
    • Add @patchBlueprint for Blueprint PATCH requests
  • Update Routing for <BlueprintSettings />
  • Update Blueprint Detail & Grid Views
  • Chore Code Cleanups & Rebase & Linting
  • Test Blueprint Settings Workflow
  • Test Create Workflow
  • Test Production Build

Description

This PR adds Blueprint Settings feature to Config-UI. Users will now be able to modify/edit specific aspects of a Blueprint (dependent on its MODE) after having created one. Providers such as Jenkins and TAPD will have limited-to-no data scope editing functionality because Transformation settings are not yet required for these providers.

Editable Properties (Settings) ALL MODES

  • Blueprint Name
  • Sync Frequency
  • Enable / Disable Stage (Toggle Switch)

NORMAL Mode Blueprints NORMAL

  • Projects Names (GitHub), Project IDs (GitLab) & Boards (JIRA)
  • Data Entities (All Providers)
  • Transformation Settings

ADVANCED Mode Blueprints ADVANCED

  • Edit Plan (Task) JSON

Does this close any open issues?

#2615

Screenshots

[<PENDING>]

Screen Shot 2022-08-05 at 10 59 45 AM

Screen Shot 2022-08-05 at 12 35 16 PM

Screen Shot 2022-08-05 at 12 35 26 PM

Screen Shot 2022-08-10 at 9 23 47 AM

Screen Shot 2022-08-10 at 9 24 16 AM

Screen Shot 2022-08-12 at 7 20 22 PM

Screen Shot 2022-08-12 at 7 20 32 PM

Screen Shot 2022-08-12 at 7 20 57 PM

Screen Shot 2022-08-12 at 7 43 18 PM

Screen Shot 2022-08-12 at 7 43 45 PM

Screen Shot 2022-08-12 at 7 45 32 PM

Screen Shot 2022-08-12 at 7 47 51 PM

@e2corporation e2corporation self-assigned this Aug 2, 2022
@e2corporation e2corporation force-pushed the jc-2615-blueprint-settings branch 2 times, most recently from a32e253 to 8dad80e Compare August 8, 2022 12:53
@e2corporation
Copy link
Copy Markdown
Contributor Author

Config-UI / Production Build Log

shogun@z06 config-ui % npm run build-production

> frontend@0.1.0 build-production
> webpack --config webpack.production.config.js --mode production

Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
Browserslist: caniuse-lite is outdated. Please run:
  npx browserslist@latest --update-db
  Why you should do it regularly: https://github.com/browserslist/browserslist#browsers-data-updating
Hash: f5a9868e017fbf351020
Version: webpack 4.46.0
Time: 24581ms
Built at: 08/12/2022 7:48:57 PM

production-build.log

@e2corporation e2corporation added component/config-ui This issue or PR relates to config-ui pr-type/feature-development This PR is to develop a new feature labels Aug 13, 2022
@e2corporation e2corporation added this to the v0.13.0 milestone Aug 13, 2022
@e2corporation e2corporation linked an issue Aug 13, 2022 that may be closed by this pull request
3 tasks
@e2corporation e2corporation force-pushed the jc-2615-blueprint-settings branch 2 times, most recently from 1c5e5ee to 17f7953 Compare August 13, 2022 06:03
@e2corporation e2corporation requested a review from klesh August 13, 2022 14:04
@e2corporation e2corporation force-pushed the jc-2615-blueprint-settings branch from 4be6cbc to befd1c9 Compare August 17, 2022 03:19
@e2corporation e2corporation changed the title feat config-ui: blueprint settings management (edit blueprint) Draft feat config-ui: blueprint settings management (edit blueprint) Aug 17, 2022
@e2corporation e2corporation marked this pull request as ready for review August 17, 2022 04:45
@e2corporation e2corporation force-pushed the jc-2615-blueprint-settings branch from 9695f72 to d0a5880 Compare August 17, 2022 16:48
Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit 3b24e45 into apache:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/config-ui This issue or PR relates to config-ui pr-type/feature-development This PR is to develop a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Config UI] Blueprint Stage II: Blueprint Editing

2 participants