Skip to content

fix: fix walk fields not filter struct#2661

Merged
klesh merged 1 commit into
apache:mainfrom
merico-ai:walk-fields
Aug 3, 2022
Merged

fix: fix walk fields not filter struct#2661
klesh merged 1 commit into
apache:mainfrom
merico-ai:walk-fields

Conversation

@mappjzc
Copy link
Copy Markdown
Contributor

@mappjzc mappjzc commented Aug 2, 2022

Summary

Add TestWalkFields
Fix WalkFileds lost to filter the struct.

Does this close any open issues?

close #2652

Screenshots

image

Other Information

Any other information that is important to this PR.

Add TestWalkFields
Fix WalkFileds lost to filter the struct.

Nddtfjiang <zhicheng.jiang@merico.dev>
Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit f324b4e into apache:main Aug 3, 2022
mindlesscloud pushed a commit that referenced this pull request Aug 7, 2022
Add TestWalkFields
Fix WalkFileds lost to filter the struct.

Nddtfjiang <zhicheng.jiang@merico.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][DAL] Dalgorm.GetPrimaryKeyFields cannot return primarykey of type time.Time

2 participants