Skip to content

fix: jira changelog.FromValue & changelog.ToValue #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klesh merged 2 commits into from
Aug 8, 2022
Merged

fix: jira changelog.FromValue & changelog.ToValue #2692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dca44e
fix: switch back to the API /rest/api/2/status for compatibility
mindlesscloud Aug 8, 2022
551d3f4
refactor: rename some csv files
mindlesscloud Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 3 additions & 44 deletions plugins/jira/e2e/changelog_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,51 +38,10 @@ func TestIssueChangelogDataFlow(t *testing.T) {
},
}

// import raw data table
dataflowTester.ImportCsvIntoRawTable("./raw_tables/_raw_jira_api_issue_changelogs.csv", "_raw_jira_api_issue_changelogs")

// verify changelog extraction
dataflowTester.FlushTabler(&models.JiraIssueChangelogs{})
dataflowTester.FlushTabler(&models.JiraIssueChangelogItems{})
dataflowTester.FlushTabler(&models.JiraAccount{})
dataflowTester.Subtask(tasks.ExtractIssueChangelogsMeta, taskData)
dataflowTester.VerifyTable(
models.JiraIssueChangelogs{},
"./snapshot_tables/_tool_jira_issue_changelogs.csv",
[]string{
"connection_id",
"changelog_id",
"issue_id",
"author_account_id",
"author_display_name",
"author_active",
"created",
"issue_updated",
"_raw_data_params",
"_raw_data_table",
"_raw_data_id",
"_raw_data_remark",
},
)

dataflowTester.VerifyTable(
models.JiraIssueChangelogItems{},
"./snapshot_tables/_tool_jira_issue_changelog_items.csv",
[]string{
"connection_id",
"changelog_id",
"field",
"field_type",
"field_id",
"from_value",
"from_string",
"to_value",
"to_string",
},
)

// verify changelog conversion
dataflowTester.ImportCsvIntoTabler("./snapshot_tables/_tool_jira_board_issues_for_changelog.csv", &models.JiraBoardIssue{})
dataflowTester.ImportCsvIntoTabler("./snapshot_tables/_tool_jira_issue_changelogs.csv", &models.JiraIssueChangelogs{})
dataflowTester.ImportCsvIntoTabler("./snapshot_tables/_tool_jira_issue_changelog_items.csv", &models.JiraIssueChangelogItems{})
dataflowTester.ImportCsvIntoTabler("./snapshot_tables/_tool_jira_statuses.csv", &models.JiraStatus{})
dataflowTester.FlushTabler(&ticket.IssueChangelogs{})
dataflowTester.Subtask(tasks.ConvertIssueChangelogsMeta, taskData)
dataflowTester.VerifyTable(
Expand Down
28 changes: 28 additions & 0 deletions plugins/jira/e2e/issue_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,34 @@ func TestIssueDataFlow(t *testing.T) {
"./snapshot_tables/_tool_jira_board_issues.csv",
[]string{"connection_id", "board_id", "issue_id"},
)
dataflowTester.VerifyTable(
models.JiraIssueChangelogs{},
"./snapshot_tables/_tool_jira_issue_changelogs.csv",
[]string{
"connection_id",
"changelog_id",
"issue_id",
"author_account_id",
"author_display_name",
"author_active",
"created",
"issue_updated",
},
)
dataflowTester.VerifyTable(
models.JiraIssueChangelogItems{},
"./snapshot_tables/_tool_jira_issue_changelog_items.csv",
[]string{
"connection_id",
"changelog_id",
"field",
"field_type",
"field_id",
"from_value",
"from_string",
"to_value",
"to_string"},
)

// verify issue conversion
dataflowTester.FlushTabler(&ticket.Issue{})
Expand Down
31 changes: 0 additions & 31 deletions plugins/jira/e2e/raw_tables/_raw_jira_api_issue_changelogs.csv
View file
Open in desktop

This file was deleted.

54 changes: 54 additions & 0 deletions plugins/jira/e2e/raw_tables/_raw_jira_api_status.csv
View file
Open in desktop

Large diffs are not rendered by default.

719 changes: 689 additions & 30 deletions plugins/jira/e2e/snapshot_tables/_tool_jira_issue_changelog_items.csv
View file
Open in desktop

Large diffs are not rendered by default.

549 changes: 518 additions & 31 deletions plugins/jira/e2e/snapshot_tables/_tool_jira_issue_changelogs.csv
View file
Open in desktop

Large diffs are not rendered by default.

37 changes: 37 additions & 0 deletions plugins/jira/e2e/snapshot_tables/_tool_jira_statuses.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
connection_id,id,name,status_category,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark
2,1,Open,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,453,
2,10033,To Do,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,455,
2,10034,Done,done,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,456,
2,10039,Backlog,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,457,
2,10040,缺陷,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,458,
2,10045,技术开发中,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,459,
2,10064,Under review,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,460,
2,10066,QUESTION,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,461,
2,10067,故事,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,462,
2,10068,已完成,done,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,463,
2,10074,开发中,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,464,
2,10078,已发布,done,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,465,
2,10080,设计中,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,466,
2,10084,测试中,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,467,
2,10090,待发布,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,468,
2,10103,Suggestion,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,469,
2,10104,挂起中,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,470,
2,10112,需求挂起中,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,471,
2,10114,Selected for Development,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,472,
2,10133,处理中,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,476,
2,10134,打开,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,477,
2,10135,待评分,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,478,
2,10136,已初筛,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,479,
2,10137,细化中,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,480,
2,10138,概设中,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,481,
2,10139,重新打开,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,482,
2,10140,开发自测,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,483,
2,10141,发布中,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,484,
2,10142,代码评审,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,485,
2,10143,已关闭,done,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,486,
2,10144,已解决,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,487,
2,10145,无效的,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,488,
2,10146,暂不修改,done,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,489,
2,10147,分析中,new,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,490,
2,3,In Progress,indeterminate,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,452,
2,6,Closed,done,"{""ConnectionId"":2,""BoardId"":8}",_raw_jira_api_status,454,
Loading