Skip to content

feat(gitlab): add projects api#2705

Merged
klesh merged 1 commit into
apache:mainfrom
merico-ai:2376-featuregitlab-api-to-list-all-projects-for-gitlab
Aug 10, 2022
Merged

feat(gitlab): add projects api#2705
klesh merged 1 commit into
apache:mainfrom
merico-ai:2376-featuregitlab-api-to-list-all-projects-for-gitlab

Conversation

@warren830
Copy link
Copy Markdown
Contributor

Summary

add a proxy for gitlab, which can allow config-ui to use:
http://localhost:4000/api/plugins/gitlab/connections/3/proxy/rest/projects?visibility=private to request all gitlab projects which granted to the specified user with the given token

Does this close any open issues?

relate to #2376

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @e2corporation Please check it out

Comment thread plugins/gitlab/api/proxy.go Outdated
if err != nil {
return nil, err
}
fmt.Println(input.Params["path"])
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove debugging code

@warren830 warren830 force-pushed the 2376-featuregitlab-api-to-list-all-projects-for-gitlab branch from 55d006d to c2dd8eb Compare August 10, 2022 01:32
Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants