Table info#2720
Merged
Merged
Conversation
Add some struct for table info. Add RegisterTablesInfo for regist the table info. Add GetTotalInfo,TraversalTable,Traversal for get the table info. Nddtfjiang <zhicheng.jiang@merico.dev>
Add RegisterTablesInfo for gitlab. Add GetTableInfo api to get the table info for gitlab. Nddtfjiang <zhicheng.jiang@merico.dev>
mappjzc
force-pushed
the
table-info
branch
3 times, most recently
from
3b5ddb8 to
d417e4c
Compare
remove the table data saved. Nddtfjiang <zhicheng.jiang@merico.dev>
klesh
reviewed
Aug 11, 2022
| type TableInfo struct { | ||
| name string | ||
| describe string | ||
| table schema.Tabler |
Contributor
There was a problem hiding this comment.
Do NOT depends on gorm directly
| "gorm.io/gorm/schema" | ||
| ) | ||
|
|
||
| type TableInfo struct { |
Contributor
There was a problem hiding this comment.
Lets call it Model instead of Table
| // @Tags plugins/gitlab | ||
| // @Success 200 | ||
| // @Router /plugins/gitlab/table [GET] | ||
| func GetTableInfo(input *core.ApiResourceInput) (*core.ApiResourceOutput, error) { |
Contributor
There was a problem hiding this comment.
What we need is to provide an API on Framework level to describe meta information for all plugin including Subtasks/Models.
Not on Plugin API level, please remove it.
remote api to show tables info at gitlab. add GetTablesInfo for all plugin Nddtfjiang <zhicheng.jiang@merico.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add some struct for table info.
Add RegisterTablesInfo for regist the table info.
Add GetTotalInfo,TraversalTable,Traversal for get the table info.
Add RegisterTablesInfo for gitlab.
Add GetTableInfo api to get the table info for gitlab.
Does this close any open issues?
#1875
Screenshots
Other Information
Any other information that is important to this PR.