[feat-2134][framework]: Rework the error management code in the Backend#2763
Merged
Conversation
5 tasks
keon94
force-pushed
the
issues/2134
branch
2 times, most recently
from
b5b7505 to
32d733e
Compare
Contributor
Author
|
I've been working on improving our error management infrastructure, and have implemetend a work-in-progress implementation of my ideas. Obviously, I'll have to go and find all the places where we are throwing errors and pass them through this new API. But I'd like to get your input as well before I do too much, so please have a look. Here's a screenshot of a temporary test suite I wrote: And the results (the errors printed) |
keon94
commented
Aug 18, 2022
keon94
force-pushed
the
issues/2134
branch
2 times, most recently
from
c0fc602 to
ed8250a
Compare
Contributor
Author
|
Example after including the optional "user-friendly" feature |
keon94
force-pushed
the
issues/2134
branch
4 times, most recently
from
794900f to
7551e56
Compare
keon94
force-pushed
the
issues/2134
branch
15 times, most recently
from
92657a0 to
a01f7a0
Compare
keon94
force-pushed
the
issues/2134
branch
2 times, most recently
from
7c7aea7 to
7dd41dd
Compare
Contributor
Author
|
Example backend log message with "test-jira-connection" erroring out (stacktrace enabled) Response as seen by the front-end |
keon94
force-pushed
the
issues/2134
branch
4 times, most recently
from
9e41cae to
96a09de
Compare
Contributor
Author
|
@e2corporation with my new error messaging scheme (sample here) I am returning a multi-line cause-hierarchy of messages on the response. Let me know your thoughts. cc @klesh |
added 14 commits
September 1, 2022 17:46
3 tasks
yuqiangabab
added a commit
to yuqiangabab/incubator-devlake
that referenced
this pull request
Sep 4, 2022
* main: (59 commits) [feat-2134][framework]: Rework the error management code in the Backend (apache#2763) fix: add missing jenkins proxy field on save (apache#2903) feat: setup database migration alert dialog on ui (apache#2859) fix: cached plan must not change result type in postgres fix(configui): use id instead of key fix(jira): use issuetype.name if issuetype has no untranslatedName fix: add `type` field in `boards` table (apache#2885) fix: change the filed user_id to account_id in table pr_comments and issue_comments (apache#2850) fix: fix a rebase bug (apache#2916) fix: source_type shorthand feat: support source dsn fix(jira): add jira 7 support feat: dbt add download packages functions and logging functions feat: add page for history runs at blueprint state (apache#2899) refactor: replace connectionLimit with exist state (apache#2895) fix: fix the wrong router when adding a connection (apache#2893) fix: update wording and typo for pr template (apache#2902) feat: jira support define standard status (apache#2881) docs: update pr template (apache#2900) fix: move setAllConnections to the right statement (apache#2889) ... # Conflicts: # models/migrationscripts/register.go # services/blueprint.go # services/pipeline.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
label(bug, feature etc.)Summary
Does this close any open issues?
Closes #2134
Screenshots
Include any relevant screenshots here.
Other Information
Blocks #2907