fix: fix for ci#2770
Merged
Merged
Conversation
e2corporation
approved these changes
Aug 22, 2022
Contributor
e2corporation
left a comment
e2corporation
left a comment
There was a problem hiding this comment.
@likyh Nice work, one small fix needed (rateLimit key) and rebase then LGTM.
| expect(response.body[0]).to.have.property('storyPointField') | ||
| expect(response.body[0]).to.have.property('remotelinkCommitShaPattern') | ||
| expect(response.body[0]).to.have.property('proxy') | ||
| expect(response.body[0]).to.have.property('rateLimitPerHour') |
Contributor
There was a problem hiding this comment.
The response key from the API is actually just rateLimit. All property assertions for rate limit should be updated to rateLimit.
Contributor
Author
There was a problem hiding this comment.
The response is rateLimitPerHour. Is it changed in any unmerged PR?
Contributor
There was a problem hiding this comment.
@likyh After rebuilding main it looks like it has been changed to rateLimitPerHour on response as well. No change necessary in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix some connection ci and skip pipeline ci