Skip to content

feat: add connection rate limit setting#2783

Merged
klesh merged 6 commits into
apache:mainfrom
merico-ai:jc-931-connection-ratelimit
Aug 22, 2022
Merged

feat: add connection rate limit setting#2783
klesh merged 6 commits into
apache:mainfrom
merico-ai:jc-931-connection-ratelimit

Conversation

@e2corporation
Copy link
Copy Markdown
Contributor

@e2corporation e2corporation commented Aug 19, 2022 •
edited
Loading

📦 Config-UI / Data Integrations / Connections - Rate Limit

  • Add Rate Limit Connection Form Field
  • Update Connection Manager Hook (Define rateLimit)
  • Update Component Properties
  • Test Rate Limit Setting

Description

This PR adds the Rate Limit (per hour) numeric setting for the Connections definition for All Data Providers (Plugins). The default value is 0. NOTE: It's property is NOT included when Testing a connection.

Does this close any open issues?

#931

Screenshots

Screen Shot 2022-08-19 at 7 19 03 PM

Screen Shot 2022-08-19 at 7 25 21 PM

@e2corporation e2corporation self-assigned this Aug 19, 2022
@e2corporation e2corporation added pr-type/feature-development This PR is to develop a new feature component/config-ui This issue or PR relates to config-ui labels Aug 19, 2022
@e2corporation e2corporation added this to the v0.13.0 milestone Aug 19, 2022
@e2corporation e2corporation changed the title feat: add connection rate limit setting feat: add connection rate limit setting | Draft Aug 19, 2022
@e2corporation e2corporation changed the title feat: add connection rate limit setting | Draft feat: add connection rate limit setting | Draft Aug 19, 2022
@e2corporation
Copy link
Copy Markdown
Contributor Author

e2corporation commented Aug 19, 2022

@klesh @warren830 Is BE currently storing rateLimit? It's still returning 0 even though request payload sends a different value.

@e2corporation e2corporation marked this pull request as ready for review August 20, 2022 05:44
@e2corporation e2corporation changed the title feat: add connection rate limit setting | Draft feat: add connection rate limit setting Aug 20, 2022
@e2corporation e2corporation mentioned this pull request Aug 20, 2022
Merged
5 tasks
@e2corporation
Copy link
Copy Markdown
Contributor Author

e2corporation commented Aug 20, 2022

⚠️ NOTE: This PR may conflict with PR #2782. The changes on PR's #2782 blueprint-settings.jsx should be preferred.

klesh
klesh reviewed Aug 20, 2022
View reviewed changes
Comment thread config-ui/src/data/NullConnection.js
@e2corporation e2corporation marked this pull request as draft August 20, 2022 07:06
@e2corporation e2corporation marked this pull request as ready for review August 20, 2022 07:12
@e2corporation
Copy link
Copy Markdown
Contributor Author

e2corporation commented Aug 20, 2022

@klesh PR Updated ready to go.

klesh
klesh approved these changes Aug 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit 7e6723d into apache:main Aug 22, 2022
@e2corporation e2corporation mentioned this pull request Aug 22, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klesh klesh klesh approved these changes

@warren830 warren830 Awaiting requested review from warren830

Assignees

@e2corporation e2corporation

Labels

component/config-ui This issue or PR relates to config-ui pr-type/feature-development This PR is to develop a new feature

Projects

None yet

Milestone

v0.13.0

Development

Successfully merging this pull request may close these issues.

2 participants

@e2corporation @klesh