Skip to content

fix: fetch proxy only if jira is an enabled provider#2795

Merged
klesh merged 1 commit into
apache:mainfrom
merico-ai:jc-2789-restrict-jira-proxy-fetching
Aug 23, 2022
Merged

fix: fetch proxy only if jira is an enabled provider#2795
klesh merged 1 commit into
apache:mainfrom
merico-ai:jc-2789-restrict-jira-proxy-fetching

Conversation

@e2corporation
Copy link
Copy Markdown
Contributor

@e2corporation e2corporation commented Aug 22, 2022

🔁 Config-UI / Blueprints / Create Blueprint

  • Fetch JIRA Proxy Resources only if JIRA is an Enabled (selected) Provider
  • Test Create Workflow

This PR adds a needed restriction to the Create Blueprint Workflow so that JIRA Proxy API resources are only fetched if JIRA is an enabled Provider (ie. the user selects a JIRA connection for the current blueprint). In a scenario where JIRA is not detected, such as a blueprint with GitHub only -- API request calls for JIRA resources will not be made.

Does this close any open issues?

#2789

@e2corporation e2corporation self-assigned this Aug 22, 2022
@e2corporation e2corporation added pr-type/bug-fix This PR fixes a bug component/config-ui This issue or PR relates to config-ui labels Aug 22, 2022
@e2corporation e2corporation added this to the v0.13.0 milestone Aug 22, 2022
@e2corporation e2corporation force-pushed the jc-2789-restrict-jira-proxy-fetching branch from 6949130 to 79b573b Compare August 22, 2022 14:39
@e2corporation e2corporation requested a review from klesh August 22, 2022 14:39
@e2corporation e2corporation marked this pull request as ready for review August 22, 2022 14:39
Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit 028f343 into apache:main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/config-ui This issue or PR relates to config-ui pr-type/bug-fix This PR fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][config-ui] blueprint keep requesting jira connection when it was not selected

2 participants