Skip to content

fix: github since parameter does not work #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
warren830 merged 2 commits into from
Aug 23, 2022
Merged

fix: github since parameter does not work #2803

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee344fe
fix: github since parameter does not work
abeizn Aug 23, 2022
c018d5c
Merge branch 'apache:main' into fix#2791
abeizn Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions plugins/github/impl/impl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ package impl

import (
"fmt"
"time"

"github.com/apache/incubator-devlake/migration"
"github.com/apache/incubator-devlake/plugins/core"
Expand Down Expand Up @@ -131,6 +132,8 @@ func (plugin Github) SubTaskMetas() []core.SubTaskMeta {
}

func (plugin Github) PrepareTaskData(taskCtx core.TaskContext, options map[string]interface{}) (interface{}, error) {
logger := taskCtx.GetLogger()
logger.Debug("%v", options)
op, err := tasks.DecodeAndValidateTaskOptions(options)
if err != nil {
return nil, err
Expand All @@ -145,15 +148,28 @@ func (plugin Github) PrepareTaskData(taskCtx core.TaskContext, options map[strin
return nil, fmt.Errorf("unable to get github connection by the given connection ID: %v", err)
}

var since time.Time
if op.Since != "" {
since, err = time.Parse("2006-01-02T15:04:05Z", op.Since)
if err != nil {
return nil, fmt.Errorf("invalid value for `since`: %w", err)
}
}

apiClient, err := tasks.CreateApiClient(taskCtx, connection)
if err != nil {
return nil, fmt.Errorf("unable to get github API client instance: %v", err)
}

return &tasks.GithubTaskData{
taskData := &tasks.GithubTaskData{
Options: op,
ApiClient: apiClient,
}, nil
}

if !since.IsZero() {
taskData.Since = &since
logger.Debug("collect data updated since %s", since)
}
return taskData, nil
}

func (plugin Github) RootPkgPath() string {
Expand Down