Skip to content

fix(m1): mysql image cannot be pulled#2946

Merged
klesh merged 1 commit into
apache:mainfrom
ReMatter:fix-mysql-in-m1-chip
Sep 6, 2022
Merged

fix(m1): mysql image cannot be pulled#2946
klesh merged 1 commit into
apache:mainfrom
ReMatter:fix-mysql-in-m1-chip

Conversation

@nicoabie
Copy link
Copy Markdown

@nicoabie nicoabie commented Sep 4, 2022

⚠️   Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

remove platform and move mysql version to latest

Does this close any open issues?

Closes #2945

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@abeizn
Copy link
Copy Markdown
Contributor

abeizn commented Sep 5, 2022

good job, v8.0.30 does not need platform.

@warren830
Copy link
Copy Markdown
Contributor

@nicoabie I don't think this parameter needs to be removed if you are M1 arm64 chip. What is your docker-compose version?

I think I know this problem, for m1, we cannot pull mysql:8.0.26. We can only pull 8.0.30. We can change it to mysql:8

@warren830
Copy link
Copy Markdown
Contributor

This also relates to #2642

@warren830
Copy link
Copy Markdown
Contributor

Nice work, thanks for your contribution @nicoabie

@Startrekzky
Copy link
Copy Markdown
Contributor

Hi @nicoabie , there is an error in the lint check of the commit message.
Try to re-push this commit again using the commit message 'fix: remove platform and move mysql version to latest'. Thanks

Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh merged commit d9d500e into apache:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][devlake] mysql image with M1 arm64 chip

5 participants