Skip to content

fix: bitbucket generated wrong clone url#3315

Merged
mindlesscloud merged 3 commits into
apache:mainfrom
merico-ai:fix-bitbucket-private-repo
Oct 9, 2022
Merged

fix: bitbucket generated wrong clone url#3315
mindlesscloud merged 3 commits into
apache:mainfrom
merico-ai:fix-bitbucket-private-repo

Conversation

@mindlesscloud
Copy link
Copy Markdown
Contributor

Summary

fix #3312 [Bug][Bitbucket] Bitbucket fails to clone private repo via gitextractor
Fill in the correct username and password on creating the clone URL

Does this close any open issues?

Closes #3312

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@mindlesscloud mindlesscloud force-pushed the fix-bitbucket-private-repo branch from cb6a072 to 5c405d1 Compare October 8, 2022 16:19
@mindlesscloud mindlesscloud force-pushed the fix-bitbucket-private-repo branch from 5c405d1 to c75ee42 Compare October 9, 2022 12:21
Copy link
Copy Markdown
Contributor

@warren830 warren830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mindlesscloud mindlesscloud merged commit bd5ce8d into apache:main Oct 9, 2022
@warren830 warren830 deleted the fix-bitbucket-private-repo branch October 9, 2022 12:32
warren830 pushed a commit that referenced this pull request Oct 11, 2022
* fix: bitbucket generated wrong clone url

* fix: e2e test

* refactor: unit test instead of e2e
mindlesscloud added a commit that referenced this pull request Oct 12, 2022
* fix: bitbucket generated wrong clone url

* fix: e2e test

* refactor: unit test instead of e2e
warren830 pushed a commit that referenced this pull request Oct 17, 2022
* fix: bitbucket generated wrong clone url

* fix: e2e test

* refactor: unit test instead of e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Bitbucket] Bitbucket fails to clone private repo via gitextractor

2 participants