Skip to content

feat: jira supports timefilter by updated_at#4408

Merged
likyh merged 4 commits into
apache:release-v0.15from
merico-ai:kw-4403-timefilter
Feb 15, 2023
Merged

feat: jira supports timefilter by updated_at#4408
likyh merged 4 commits into
apache:release-v0.15from
merico-ai:kw-4403-timefilter

Conversation

@klesh
Copy link
Copy Markdown
Contributor

@klesh klesh commented Feb 13, 2023

Summary

In order to address issue #4403 , the following actions were taken:

  1. added TimeAfter to collector_state as well as jira TaskOptions and TaskData
  2. ApiCollectorStateManager.IsIncremental was modified to take TimeAfter as the First Factor to consider, or fallback to CreatedDateAfter if TimeAfter omitted. In other words, TimeAfter would override the CreatedDateAfter option
  3. JIRA issue_collector was modified to follow the principle accordingly

Does this close any open issues?

Closes #4403

Screenshots

The initial collection, should respect the timeAfter option
1st-collection

Whenever an older issue got updated, it should be collected.
3th-newly-updated-issues-got-collected

@klesh klesh changed the base branch from main to release-v0.15 February 13, 2023 13:19
Comment thread plugins/jira/tasks/issue_collector.go Outdated
Copy link
Copy Markdown
Contributor

@likyh likyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A temp solution. LGTM

Comment thread models/migrationscripts/20230213_add_updated_date_after_to_collector_state.go Outdated
@klesh klesh force-pushed the kw-4403-timefilter branch from fc379c8 to 4ffee39 Compare February 14, 2023 02:22
Copy link
Copy Markdown
Contributor

@warren830 warren830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klesh klesh force-pushed the kw-4403-timefilter branch from bb1c444 to 75c9083 Compare February 14, 2023 06:49
@klesh klesh changed the title feat: jira supports timefilter by updated_date feat: jira supports timefilter by updated_at Feb 14, 2023
@likyh likyh merged commit 1e4f03d into apache:release-v0.15 Feb 15, 2023
@likyh likyh deleted the kw-4403-timefilter branch February 15, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Jira] The behaviour of createdDateAfter option does not fit the user scenario

3 participants