Skip to content

fix: monthly cfr in DORA dashboard#4974

Merged
abeizn merged 1 commit into
apache:mainfrom
merico-ai:issue-4610
Apr 20, 2023
Merged

fix: monthly cfr in DORA dashboard#4974
abeizn merged 1 commit into
apache:mainfrom
merico-ai:issue-4610

Conversation

@Startrekzky
Copy link
Copy Markdown
Contributor

@Startrekzky Startrekzky commented Apr 19, 2023

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

  1. fix the monthly chart of CFR, the change of this chart somehow was not included in fix: update CFR logic #4616
  2. change the logic to find incidents of each deployment
  3. change the font size/color of values

Does this close any open issues?

Closes #4610

Screenshots

image

Test Information

In the test environment, there were 197 deployments, 38 of which caused incidents. I checked all original deployments and incidents and the metrics were right.

Copy link
Copy Markdown
Contributor

@abeizn abeizn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abeizn abeizn merged commit e69fed6 into apache:main Apr 20, 2023
abeizn pushed a commit that referenced this pull request Apr 20, 2023
Co-authored-by: Startrekzky <kaiyun.zhang@merico.dev>
chenggui53 pushed a commit to chenggui53/incubator-devlake that referenced this pull request May 5, 2023
Co-authored-by: Startrekzky <kaiyun.zhang@merico.dev>
chenggui53 pushed a commit to chenggui53/incubator-devlake that referenced this pull request May 5, 2023
Co-authored-by: Startrekzky <kaiyun.zhang@merico.dev>
@Startrekzky Startrekzky deleted the issue-4610 branch August 16, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Metric] The way to calculate Change Failure Rate is not accurate

3 participants