fix: resolution_date is earlier than created_date#4998
Merged
abeizn merged 1 commit intoApr 21, 2023
Conversation
likyh
approved these changes
Apr 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before going any further, let's take a look at an example.
The output of this piece of code would be "hello", because the
blob2has no "a" key, the fieldf.Awould keep the value set at the last time.The
ExtractExistRawDatafunction in theGraphqlCollectorsuffers from the same issue. During each iteration of the loop, the same query object is being populated by a call tojson.Unmarshal, causing the previous field values to persist. To fix this issue, we propose creating a new query object during each iteration of the loop.Here's the relevant code:
Does this close any open issues?
Closes #4988
Closes #4989