Skip to content

5082 fix patch tx rule#5094

Merged
hezyin merged 1 commit into
apache:mainfrom
merico-ai:5082_fix_patch_tx_rule
May 6, 2023
Merged

5082 fix patch tx rule#5094
hezyin merged 1 commit into
apache:mainfrom
merico-ai:5082_fix_patch_tx_rule

Conversation

@CamilleTeruel
Copy link
Copy Markdown
Contributor

Summary

Fix the PATCH endpoint of remote plugin transformation rules API.
Refactor and add tests

Does this close any open issues?

Closes #5082

@CamilleTeruel CamilleTeruel requested a review from hezyin May 4, 2023 16:45
Comment thread backend/test/helper/api.go Outdated
Decoding the body should support conversion of string to time.Time.
@CamilleTeruel CamilleTeruel force-pushed the 5082_fix_patch_tx_rule branch from 4d6a4ad to cf3435f Compare May 5, 2023 13:30
Copy link
Copy Markdown
Contributor

@hezyin hezyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hezyin hezyin merged commit ab9dac4 into apache:main May 6, 2023
@hezyin
Copy link
Copy Markdown
Contributor

hezyin commented May 6, 2023

This fix needs to be cherry-picked back to release-v0.17

hezyin pushed a commit that referenced this pull request May 6, 2023
Decoding the body should support conversion of string to time.Time.

Co-authored-by: Camille Teruel <camille.teruel@meri.co>
@hezyin hezyin mentioned this pull request May 6, 2023
klesh pushed a commit that referenced this pull request May 6, 2023
Decoding the body should support conversion of string to time.Time.

Co-authored-by: Camille Teruel <camille.teruel@gmail.com>
Co-authored-by: Camille Teruel <camille.teruel@meri.co>
@keon94 keon94 added this to the v0.17.0 milestone May 18, 2023
@keon94 keon94 added needs-cherrypick-v0.17 cherrypick-completed Use this alongside needs-cherrypick-* labels after the PR has been cherrypicked. labels May 18, 2023
@CamilleTeruel CamilleTeruel deleted the 5082_fix_patch_tx_rule branch May 31, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick-completed Use this alongside needs-cherrypick-* labels after the PR has been cherrypicked. needs-cherrypick-v0.17

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Azure DevOps] Error when editing the deployment regex of an existing transformation rule

3 participants