Skip to content

Fix exception on 204 when collecting jobs#5300

Merged
hezyin merged 2 commits into
apache:mainfrom
merico-ai:5083_exception_on_204
May 30, 2023
Merged

Fix exception on 204 when collecting jobs#5300
hezyin merged 2 commits into
apache:mainfrom
merico-ai:5083_exception_on_204

Conversation

@CamilleTeruel
Copy link
Copy Markdown
Contributor

Summary

Fix error when collecting jobs of builds that failed because of bad azure-pipelines.yaml.

Does this close any open issues?

Closes #5083

@CamilleTeruel CamilleTeruel requested a review from hezyin May 26, 2023 15:08
@CamilleTeruel CamilleTeruel force-pushed the 5083_exception_on_204 branch 3 times, most recently from f4c26c0 to 7c52e91 Compare May 29, 2023 14:12
@CamilleTeruel CamilleTeruel self-assigned this May 29, 2023
@CamilleTeruel CamilleTeruel force-pushed the 5083_exception_on_204 branch from 7c52e91 to 4c7ee4a Compare May 30, 2023 11:24
Copy link
Copy Markdown
Contributor

@hezyin hezyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hezyin hezyin merged commit 45e7efb into apache:main May 30, 2023
chenggui53 pushed a commit to chenggui53/incubator-devlake that referenced this pull request Jun 6, 2023
* fix: Do not raise APIException when status < 400

* fix: Let jobs endpoint handle 204 NO CONTENT status

---------

Co-authored-by: Camille Teruel <camille.teruel@meri.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Azure DevOps] Error when collecting some failed pipeline runs

2 participants