[refactor-5602]: Remove support for Zentao products#5604
Merged
Conversation
keon94
force-pushed
the
issues/5602
branch
3 times, most recently
from
d69c1f3 to
8a39408
Compare
keon94
force-pushed
the
issues/5602
branch
2 times, most recently
from
ad704ad to
dc2a4f9
Compare
keon94
commented
Jun 30, 2023
| @@ -37,7 +37,7 @@ func TestZentaoTaskDataFlow(t *testing.T) { | |||
| Options: &tasks.ZentaoOptions{ | |||
Contributor
Author
There was a problem hiding this comment.
@mappjzc I need your help with fixing this test as I can't figure out the issue, and it looks like you might have context based on the git history.
Contributor
Author
There was a problem hiding this comment.
Interestingly, the test failure happens on my machine, but it's passing here
Contributor
Author
There was a problem hiding this comment.
No, it's a different problem
klesh
reviewed
Jun 30, 2023
| // @Success 200 {object} models.ZentaoProject | ||
| // @Failure 400 {object} shared.ApiBody "Bad Request" | ||
| // @Failure 500 {object} shared.ApiBody "Internal Error" | ||
| // @Router /plugins/zentao/connections/{connectionId}/scopes/project/{scopeId} [PATCH] |
Contributor
There was a problem hiding this comment.
the projects need to be removed from all routes
Contributor
Author
There was a problem hiding this comment.
It has been. It's just left here, commented out
Contributor
Author
There was a problem hiding this comment.
oh. I mistook it with products. Ok, give me a minute
mindlesscloud
force-pushed
the
issues/5602
branch
from
6a5ee66 to
7b1f8bd
Compare
klesh
previously approved these changes
Jul 4, 2023
klesh
approved these changes
Jul 4, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove/Comment-out code related to Zentao products for now.
ZentaoId now only takes the format "id" instead of "projects/id"
Does this close any open issues?
Closes #5602
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.