[fix-5697][Pydevlake]: Fix AddColumn op possibly deleting a column#5714
Merged
Conversation
3 tasks
| return nil | ||
| } | ||
|
|
||
| func (p *remotePluginImpl) createTable(tbl coreModels.DynamicTabler) errors.Error { |
Contributor
There was a problem hiding this comment.
This change disables all automigrations but table creation, and I thought we settled on adding a CreateTable op instead?
Contributor
Author
There was a problem hiding this comment.
Not in this ticket. I'll handle that in #5689. For now, we create tables like this, and every other migration is done manually
Contributor
|
@keon94 how about the corrupted schema? will it be fixed automatically after upgrade ? |
added 3 commits
July 21, 2023 17:51
… partially avoid conflict with manual migrations. See apache#5689 for context.
Contributor
Author
I pushed a commit to re-trigger that migration. It'll work whether that column is present or not. |
klesh
approved these changes
Jul 24, 2023
Startrekzky
added
the
cherrypick-completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What does this PR do?
Does this close any open issues?
Closes #5697
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.