feat: add full name to remote api#5724
Merged
Merged
Conversation
added 2 commits
July 21, 2023 17:33
abeizn
reviewed
Jul 25, 2023
| } | ||
|
|
||
| func (t TestFakeGitlabRepo) ScopeFullName() string { | ||
| return "" |
Contributor
Author
There was a problem hiding this comment.
It doesn't matter, beside, there is no such field in the test case
Contributor
|
where is the related issue? |
Contributor
Author
The problem was described in the PR description together. |
abeizn
pushed a commit
that referenced
this pull request
Jul 25, 2023
* feat: add full name to remote api * fix: unit test
abeizn
added
the
cherrypick-completed
klesh
pushed a commit
that referenced
this pull request
Jul 25, 2023
* feat: add full name to remote api * fix: unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
it is basically unusable when trying to search github repos and add them
This PR add a new field named
fullNameto deal with the situation.for plugins that don't have parent folders,
fullName = name, like sonarqube, jira, etcfor plugins that have parent folders,
fullName = parent folders / name, like github, gitlab, jenkins, etcsSelf test
I tested on most of the data source that I have access to. bitbucket, jira , gitlab, github, jenkins
Screenshots