Skip to content

GitHub fails after upgrade to v0.18 #5946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abeizn merged 2 commits into from
Aug 24, 2023
Merged

GitHub fails after upgrade to v0.18 #5946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f6f26f
fix: remove deprecated BlueprintScopeV200.Entities
Aug 24, 2023
854060f
fix: missing migration logic in 20230612_add_fullName
Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions backend/core/plugin/plugin_blueprint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ type BlueprintConnectionV200 struct {
type BlueprintScopeV200 struct {
Id string `json:"id"`
Name string `json:"name"`
// Deprecated: Entities is moved to the ScopeConfig struct
Entities []string `json:"entities"`
}

// MetricPluginBlueprintV200 is similar to the DataSourcePluginBlueprintV200
Expand Down
29 changes: 26 additions & 3 deletions backend/plugins/github/models/migrationscripts/20230612_add_fullName.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,18 @@ limitations under the License.
package migrationscripts

import (
"strings"

"github.com/apache/incubator-devlake/core/context"
"github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/helpers/migrationhelper"
)

type githubRepo20230612 struct {
FullName string `gorm:"type:varchar(255)"`
ConnectionId uint64 `gorm:"primaryKey"`
GithubId int `gorm:"primaryKey"`
Name string `gorm:"type:varchar(255)"`
FullName string `gorm:"type:varchar(255)"`
}

func (githubRepo20230612) TableName() string {
Expand All @@ -33,12 +39,29 @@ func (githubRepo20230612) TableName() string {
type addFullName struct{}

func (*addFullName) Up(res context.BasicRes) errors.Error {
gr := &githubRepo20230612{}
db := res.GetDal()
return db.AutoMigrate(&githubRepo20230612{})
err := db.AutoMigrate(gr)
if err != nil {
return err
}
return migrationhelper.CopyTableColumns[githubRepo20230612, githubRepo20230612](
res,
gr.TableName(),
gr.TableName(),
func(gr *githubRepo20230612) (*githubRepo20230612, errors.Error) {
fn := strings.Split(gr.Name, "/")
if len(fn) == 2 {
gr.FullName = gr.Name
gr.Name = fn[1]
}
return gr, nil
},
)
}

func (*addFullName) Version() uint64 {
return 20230612184110
return 20230612184111
}

func (*addFullName) Name() string {
Expand Down