Skip to content

fix: Whitelist external source providers types#5950

Merged
klesh merged 1 commit into
apache:mainfrom
merico-ai:5855_Fix_azure_remote_scopes
Aug 25, 2023
Merged

fix: Whitelist external source providers types#5950
klesh merged 1 commit into
apache:mainfrom
merico-ai:5855_Fix_azure_remote_scopes

Conversation

@CamilleTeruel
Copy link
Copy Markdown
Contributor

Summary

To fetch external repositories from AzDO API, we have to get "service endpoints" ids. But not all service endpoints are source providers, so we need to filter them to keep only those whose type is a supported provider type

Does this close any open issues?

Closes #5855 and #5692

To fetch external repositories from AzDO API, we have to get "service endpoints" ids.
But not all service endpoints are source providers, so we need to filter them to keep
only those whose type is a supported provider type
Copy link
Copy Markdown
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick-completed Use this alongside needs-cherrypick-* labels after the PR has been cherrypicked. needs-cherrypick-v0.18

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Azure Devops] 0.18.0 Regression: Unable to list repositories

2 participants