Skip to content

cherry pick #6484 fix(pipeline): fix potiential panic to v0.20 #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abeizn merged 1 commit into from
Nov 20, 2023
Merged

cherry pick #6484 fix(pipeline): fix potiential panic to v0.20 #6486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion backend/core/runner/run_pipeline.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ func runPipelineTasks(
return err
}

// if pipeline has been cancelled, just return.
if dbPipeline.Status == models.TASK_CANCELLED {
return nil
}

// This double for loop executes each set of tasks sequentially while
// executing the set of tasks concurrently.
for i, row := range taskIds {
Expand All @@ -90,6 +95,10 @@ func runPipelineTasks(
}
}
}
log.Info("pipeline finished in %d ms: %v", time.Now().UnixMilli()-dbPipeline.BeganAt.UnixMilli(), err)
if dbPipeline.BeganAt != nil {
log.Info("pipeline finished in %d ms: %v", time.Now().UnixMilli()-dbPipeline.BeganAt.UnixMilli(), err)
} else {
log.Info("pipeline finished at %d ms: %v", time.Now().UnixMilli(), err)
}
return err
}