fix: add collect sonarqube mode by file#6507
Merged
Merged
Conversation
leric
reviewed
Nov 23, 2023
| logger.Info("split by dir for it's count:[%d] and val:[%s]", value.Count, value.Val) | ||
| } else { | ||
| // by file | ||
| for _, issue := range body.Issues { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
leric
reviewed
Nov 27, 2023
| if value2.Count > MAXISSUECOUNT { | ||
| logger.Warn(fmt.Errorf("the issue count [%d] exceeds the maximum page size", value2.Count), "") | ||
| } else { | ||
| iterator.Push(&SonarqubeIssueIteratorNode{ |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
leric
approved these changes
Nov 28, 2023
d4x1
reviewed
Nov 28, 2023
| logger.Info("split by dir, and it's issue count:[%d] and file path:[%s]", value.Count, value.Val) | ||
| } else { | ||
| // split it by dir when it's issue count > 10000 | ||
| res2, err := data.ApiClient.Get("issues/search", url.Values{ |
Contributor
There was a problem hiding this comment.
res2 and body2 values2 should have better names.
| CreatedBefore: createdBefore, | ||
| FilePath: value2.Val, | ||
| }) | ||
| logger.Info(fmt.Sprintf("split by fil, and it's issue count:[%d] and file path:[%s]", value2.Count, value2.Val)) |
Contributor
There was a problem hiding this comment.
no need to use fmt.Sprintf. logger.Info has a format parameter.
|
|
||
| type SonarqubePageInfo struct { | ||
| Total int `json:"total"` | ||
| P int `json:"p"` |
Contributor
There was a problem hiding this comment.
what's the meaning of p and ps?
Contributor
Author
There was a problem hiding this comment.
p: 1-based page number
ps: Page size. Must be greater than 0 and less or equal than 500
| } | ||
| for _, value2 := range body2.Facets[0].Values { | ||
| if value2.Count > MAXISSUECOUNT { | ||
| logger.Warn(fmt.Errorf("the issue count [%d] exceeds the maximum page size", value2.Count), "") |
Contributor
Author
There was a problem hiding this comment.
func (log.Logger).Warn(err error, format string, a ...interface{})
The first parameter is of error type, so it is required
| "componentKeys": {fmt.Sprintf("%v", data.Options.ProjectKey)}, | ||
| "directories": {value.Val}, | ||
| "facets": {"files"}, | ||
| "ps": {"1"}, |
Contributor
There was a problem hiding this comment.
Can this work? I think it should be "ps": []string{"1"}.
Contributor
Author
There was a problem hiding this comment.
yes,
"ps": {"1"} is correct
"ps": {}string{"1"} is invalid syntax
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
* fix: add collect sonarqube mode by file * fix: update some collector logic * fix: some params * fix: update some params * fix: still need to push issues when the count exceed MAXISSUECOUNT * fix: update log format and variable name --------- Co-authored-by: Lynwee <linwei.hou@merico.dev>
Contributor
|
🤖 cherry pick finished successfully 🎉! |
github-actions
Bot
added
the
bot/auto-cherry-pick-completed
abeizn
added a commit
that referenced
this pull request
Nov 29, 2023
* fix: add collect sonarqube mode by file * fix: update some collector logic * fix: some params * fix: update some params * fix: still need to push issues when the count exceed MAXISSUECOUNT * fix: update log format and variable name --------- Co-authored-by: abeizn <zikuan.an@merico.dev> Co-authored-by: Lynwee <linwei.hou@merico.dev>
abeizn
added
needs-cherrypick-v0.20
and removed
bot/auto-cherry-pick-completed
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 29, 2023
* fix: add collect sonarqube mode by file * fix: update some collector logic * fix: some params * fix: update some params * fix: still need to push issues when the count exceed MAXISSUECOUNT * fix: update log format and variable name --------- Co-authored-by: Lynwee <linwei.hou@merico.dev>
Contributor
|
🤖 cherry pick finished successfully 🎉! |
github-actions
Bot
added
the
bot/auto-cherry-pick-completed
abeizn
added a commit
that referenced
this pull request
Nov 29, 2023
* fix: add collect sonarqube mode by file * fix: update some collector logic * fix: some params * fix: update some params * fix: still need to push issues when the count exceed MAXISSUECOUNT * fix: update log format and variable name --------- Co-authored-by: abeizn <zikuan.an@merico.dev> Co-authored-by: Lynwee <linwei.hou@merico.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: add collect sonarqube mode by file
Does this close any open issues?
Closes #6493
Screenshots
Other Information
Any other information that is important to this PR.