Skip to content

fix(dora): add deployment generator#6698

Merged
abeizn merged 6 commits into
apache:mainfrom
merico-ai:fix-jenkins-deployment
Dec 28, 2023
Merged

fix(dora): add deployment generator#6698
abeizn merged 6 commits into
apache:mainfrom
merico-ai:fix-jenkins-deployment

Conversation

@d4x1
Copy link
Copy Markdown
Contributor

@d4x1 d4x1 commented Dec 27, 2023 •
edited
Loading

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?

  1. In some plugins, such as Jenkins, user can set a job without any commit, so when converting cicd_pipelines to cicd_deployments, if pipeline has no commits, this progress should work well.
    This PR just dispart cicd_deployments generator and make sure cicd_deployments can be generated anyway.
  2. I have checked all plugins that can generate cicd_deloyments table,and make sure that if there is no commit associated to its original builds, devlake can generate cicd_deployments table anyway.

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.
image
image
image

Other Information

Any other information that is important to this PR.

@d4x1 d4x1 requested a review from abeizn December 27, 2023 13:48
@d4x1 d4x1 added the pr-type/bug-fix This PR fixes a bug label Dec 27, 2023
@d4x1 d4x1 added this to the v0.21 milestone Dec 27, 2023
abeizn
abeizn reviewed Dec 28, 2023
View reviewed changes
Comment thread backend/plugins/dora/impl/impl.go Outdated
"projectName": projectName,
},
Subtasks: []string{
tasks.DeploymentGeneratorMeta.Name,
Copy link
Copy Markdown
Contributor

@abeizn abeizn Dec 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please unify it, either use xxx.Name or write it out directly.

Copy link
Copy Markdown
Contributor Author

@d4x1 d4x1 Dec 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

abeizn
abeizn approved these changes Dec 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@abeizn abeizn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abeizn abeizn merged commit 0e3bfb5 into apache:main Dec 28, 2023
@d4x1 d4x1 mentioned this pull request Dec 28, 2023
Merged
@d4x1 d4x1 deleted the fix-jenkins-deployment branch December 28, 2023 06:56
abeizn pushed a commit that referenced this pull request Dec 28, 2023
@d4x1
cherry pick #6698 fix(dora): add deployment generator to v0.20 (#6703)
7d6ee36 
* fix(dora): add deployment generator

* fix(test): fix unit test

* fix(deployments): check and update convertor that can generate cicd_deployments

* fix(dora): make code better

* fix(plugins): fix errors when cherrying pick
@d4x1 d4x1 added the cherrypick-completed Use this alongside needs-cherrypick-* labels after the PR has been cherrypicked. label Dec 28, 2023
@d4x1
Copy link
Copy Markdown
Contributor Author

d4x1 commented Jan 2, 2024

@Startrekzky I think some sql scripts in dashboard shoule be updated too.
Such as
image

@d4x1 d4x1 mentioned this pull request Jan 3, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abeizn abeizn abeizn approved these changes

Assignees

No one assigned

Labels

cherrypick-completed Use this alongside needs-cherrypick-* labels after the PR has been cherrypicked. needs-cherrypick-v0.20 pr-type/bug-fix This PR fixes a bug

Projects

None yet

Milestone

v0.21

Development

Successfully merging this pull request may close these issues.

2 participants

@d4x1 @abeizn