refactor: deprecate specifying timeAfter via taskOptions#7323
Merged
Conversation
abeizn
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the current implementation, one can specify the
timeAftervia thetaskOptionslike the following:This looks flexible but doesn't make too much sense because a Project/Blueprint/Pipeline crunches the SAME time range of data from different data sources in most cases if not all.
So, this feature is rarely used because we have
timeAfteron the Project/Blueprint/Pipeline level, it is easier to use.For those who really need to collector different data sources with different time range can could use multiple Projects/Blueprints, or Pipelines. So no point in maintaining such a feature.
This PR remove the
timeAfteroption from thetaskOptionsfor all plugin to simply our logic and make contributors life easier.