feat: add deployment metadata to the table of the deployment frequency details dashboard#7325
Merged
Conversation
…loyment frequency' dashboard
d4x1
previously approved these changes
Apr 16, 2024
| domainlayer.DomainEntity | ||
| CicdScopeId string `gorm:"index;type:varchar(255)"` | ||
| Name string `gorm:"type:varchar(255)"` | ||
| DisplayTitle string |
Contributor
There was a problem hiding this comment.
If you don't specify a gorm type, it's will be varchar(256) by default.
It doesn't affect functionality, but it's just inconsistent.
| CSVRelPath: "./snapshot_tables/cicd_deployment_commits.csv", | ||
| IgnoreTypes: []interface{}{common.NoPKModel{}}, | ||
| IgnoreFields: []string{}, | ||
| IgnoreFields: []string{"created_date", "queued_date", "started_date", "finished_date"}, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| PipelineId int `gorm:"primaryKey"` | ||
| ProjectId int `gorm:"primaryKey"` | ||
| Ref string `gorm:"type:varchar(255)"` | ||
| WebUrl string `gorm:"type:varchar(255)"` |
Contributor
There was a problem hiding this comment.
varchar(255) maybe too short.
Startrekzky
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat: add deployment metadata to the table of the dloyment frequency details dashboard
Does this close any open issues?
Closes #7280
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.