Skip to content

fix: allow selecting FreeStyleProject in jenkins scopes UI #7411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klesh merged 1 commit into from
Apr 30, 2024
Merged

fix: allow selecting FreeStyleProject in jenkins scopes UI #7411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions backend/plugins/jenkins/api/remote_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,8 @@ func listJenkinsRemoteScopes(
getJobsPageCallBack := func(job *models.Job) errors.Error {
switch job.Class {
case "org.jenkinsci.plugins.workflow.job.WorkflowJob":
// this is a scope
Copy link
Copy Markdown
Contributor

@abeizn abeizn May 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why delete this code? It resulted in many of my scopes not being displayed. @gustavobini cc @klesh

jenkinsJob := job.ToJenkinsJob()
children = append(children, dsmodels.DsRemoteApiScopeListEntry[models.JenkinsJob]{
Type: api.RAS_ENTRY_TYPE_SCOPE,
Id: jenkinsJob.ScopeId(),
Name: jenkinsJob.ScopeName(),
FullName: jenkinsJob.ScopeFullName(),
Data: jenkinsJob,
ParentId: parentId,
})
case "org.jenkinsci.plugins.workflow.multibranch.WorkflowMultiBranchProject":
case "hudson.model.FreeStyleProject":
// this is a scope
jenkinsJob := job.ToJenkinsJob()
children = append(children, dsmodels.DsRemoteApiScopeListEntry[models.JenkinsJob]{
Expand Down