fix(jenkins): incorrect class type on multibranch jobs#7464
Merged
Conversation
gustavobini
force-pushed
the
fix/jenkins-multibranch
branch
from
86ff80e to
3ccb744
Compare
gustavobini
changed the title
The input for builds is a workflow job and not a workflow multibranch project.
gustavobini
force-pushed
the
fix/jenkins-multibranch
branch
from
3ccb744 to
5bb9c37
Compare
Contributor
Author
klesh
approved these changes
May 16, 2024
Contributor
|
LGTM, @gustavobini Thanks for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The input for builds is a workflow job and not a workflow multibranch project.
Summary
What does this PR do?
This fixes extraction of multibranch builds as it was incorrectly checking for the class type to be of the multibranch project, instead of a workflow job. Only jobs created from multibranch projects have
Inputdefined.I also noted I had only added tests covering the "jobs" aspect of the multibranch flow. This covers the rest.