Skip to content

fix: don't show link action when a plugin doesn't have scope config #7506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abeizn merged 1 commit into from
May 24, 2024
Merged

fix: don't show link action when a plugin doesn't have scope config #7506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions config-ui/src/plugins/components/scope-config/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import styled from 'styled-components';
import API from '@/api';
import { IconButton, Message } from '@/components';
import { PATHS } from '@/config';
import { getPluginConfig } from '@/plugins';
import { operator } from '@/utils';

import { PluginName } from '../plugin-name';
Expand Down Expand Up @@ -59,6 +60,8 @@ export const ScopeConfig = ({

const [operating, setOperating] = useState(false);

const pluginConfig = getPluginConfig(plugin);

const {
token: { colorPrimary },
} = theme.useToken();
Expand Down Expand Up @@ -197,15 +200,17 @@ export const ScopeConfig = ({
<Wrapper>
{contextHolder}
<span>{scopeConfigId ? scopeConfigName : 'N/A'}</span>
<IconButton
icon={<LinkOutlined />}
helptip="Associate Scope Config"
size="small"
type="link"
onClick={() => {
setType('associate');
}}
/>
{pluginConfig.scopeConfig && (
<IconButton
icon={<LinkOutlined />}
helptip="Associate Scope Config"
size="small"
type="link"
onClick={() => {
setType('associate');
}}
/>
)}
{scopeConfigId && (
<IconButton
icon={<EditOutlined />}
Expand Down