Skip to content

Tidy up Webhook APIs#7550

Merged
klesh merged 3 commits into
mainfrom
kw-webhook-deployment-no2
May 31, 2024
Merged

Tidy up Webhook APIs#7550
klesh merged 3 commits into
mainfrom
kw-webhook-deployment-no2

Conversation

@klesh
Copy link
Copy Markdown
Contributor

@klesh klesh commented May 31, 2024

Summary

Fine-grain #7545 according to the discussion with @Startrekzky

  1. Change field names of Webhook Issues API request body to camelCase
  2. Webhook Deployment API:
    • Removed pipelineId and use id as the replacement
    • Renamed createdTime to createdDate, startedTime to startedDate and endedTime to finishedDate to align with the DB schema

@klesh klesh requested a review from Startrekzky May 31, 2024 03:16
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 31, 2024
@klesh klesh changed the title Kw webhook deployment no2 Tidy up Webhook APIs May 31, 2024
@dosubot dosubot Bot added component/plugins This issue or PR relates to plugins pr-type/refactor This PR refactors existing features labels May 31, 2024
Copy link
Copy Markdown
Contributor

@Startrekzky Startrekzky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label May 31, 2024
@klesh klesh merged commit 35f814e into main May 31, 2024
@klesh klesh deleted the kw-webhook-deployment-no2 branch May 31, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer pr-type/refactor This PR refactors existing features size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants