Skip to content

kw fix webhook deployment result#7566

Merged
abeizn merged 1 commit into
mainfrom
kw-fix-webhook-deployment-result
Jun 4, 2024
Merged

kw fix webhook deployment result#7566
abeizn merged 1 commit into
mainfrom
kw-fix-webhook-deployment-result

Conversation

@klesh
Copy link
Copy Markdown
Contributor

@klesh klesh commented Jun 4, 2024

  • fix: deployment result not working

POSTED

{
    "id": "required-deplymentId-14_1",
    "createdDate":"2023-01-01T11:00:00+00:00",
    "startedDate":"2024-01-01T12:00:00+00:00",
    "finishedDate":"2024-02-02T13:00:00+00:00",
    "environment":"PRODUCTION",
    "result": "FAILURE",  <---
    "displayTitle":"this is deploy-display-title",
    "name": "this is deployment-name.",
    "deploymentCommits":[
       {
           "repoUrl":"repo-ur3",
           "refName": "release-v0.17",
           "commitSha":"c1",
           "commitMsg":"msg-1",
           "name":" it will be deployment for c1",
           "startedDate": "2024-01-02T12:00:00+00:00",
          "finishedDate": "2024-01-03T12:00:00+00:00",
           "displayTitle":"optional-custom-deployment-commit-display-title-1"
       },
       {
           "repoUrl":"repo-4",
           "refName": "release-v0.17",
           "commitSha":"c4",
           "commitMsg":"msg-4",
           "name":"it will be deployment for C4",
           "startedDate": "2024-01-02T12:00:00+00:00",
          "finishedDate": "2024-01-03T12:00:00+00:00",
           "displayTitle":"custom-deployment-commit-display-title-4"
       }
    ]
  }

GOT
image

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 4, 2024
@dosubot dosubot Bot added component/config-ui This issue or PR relates to config-ui component/plugins This issue or PR relates to plugins pr-type/bug-fix This PR fixes a bug pr-type/feature-development This PR is to develop a new feature labels Jun 4, 2024
@klesh klesh force-pushed the kw-fix-webhook-deployment-result branch from 4501120 to 4565845 Compare June 4, 2024 03:38
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 4, 2024
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jun 4, 2024
@abeizn abeizn merged commit bc246b1 into main Jun 4, 2024
@abeizn abeizn deleted the kw-fix-webhook-deployment-result branch June 4, 2024 05:49
github-actions Bot pushed a commit that referenced this pull request Jun 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2024

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions Bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Jun 4, 2024
abeizn pushed a commit that referenced this pull request Jun 4, 2024
Co-authored-by: Klesh Wong <zhenmian.huang@merico.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot/auto-cherry-pick-completed auto cherry pick completed component/config-ui This issue or PR relates to config-ui component/plugins This issue or PR relates to plugins lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug pr-type/feature-development This PR is to develop a new feature size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants