Skip to content

cherry-pick #7630 feat: default enable project plugin and remove configuration #7631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mintsweet merged 1 commit into from
Jun 19, 2024
Merged

cherry-pick #7630 feat: default enable project plugin and remove configuration #7631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config-ui/src/routes/project/detail/settings-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,10 @@ export const SettingsPanel = ({ project, onRefresh }: Props) => {
<Block
title={
<Checkbox checked={issueTrace.enable} onChange={(e) => setIssueTrace({ enable: e.target.checked })}>
Enable Issue Trace
Enable issue trace
</Checkbox>
}
description=""
description="Parse the issue status and assignee history from issue changelogs. Currently, only Jira issues are supported."
/>
<Block>
<Button type="primary" loading={operating} disabled={!name} onClick={handleUpdate}>
Expand Down
31 changes: 9 additions & 22 deletions config-ui/src/routes/project/home/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,14 @@
import { useState, useMemo, useRef } from 'react';
import { Link, useNavigate } from 'react-router-dom';
import { PlusOutlined, SettingOutlined } from '@ant-design/icons';
import { Flex, Table, Button, Modal, Input, Checkbox, message } from 'antd';
import { Flex, Table, Button, Modal, Input, message } from 'antd';

import API from '@/api';
import { PageHeader, Block, ExternalLink, IconButton } from '@/components';
import { PageHeader, Block, IconButton } from '@/components';
import { getCron, PATHS } from '@/config';
import { ConnectionName } from '@/features';
import { useRefreshData } from '@/hooks';
import { OnboardTour } from '@/routes/onboard/components';
import { DOC_URL } from '@/release';
import { formatTime, operator } from '@/utils';
import { PipelineStatus } from '@/routes/pipeline';
import { IBlueprint } from '@/types';
Expand All @@ -40,7 +39,6 @@ export const ProjectHomePage = () => {
const [pageSize] = useState(20);
const [open, setOpen] = useState(false);
const [name, setName] = useState('');
const [enableDora, setEnableDora] = useState(true);
const [saving, setSaving] = useState(false);

const nameRef = useRef(null);
Expand Down Expand Up @@ -73,7 +71,6 @@ export const ProjectHomePage = () => {
const handleHideDialog = () => {
setOpen(false);
setName('');
setEnableDora(true);
};

const handleCreate = async () => {
Expand All @@ -90,8 +87,13 @@ export const ProjectHomePage = () => {
metrics: [
{
pluginName: 'dora',
pluginOption: '',
enable: enableDora,
pluginOption: {},
enable: true,
},
{
pluginName: 'issue_trace',
pluginOption: {},
enable: true,
},
],
}),
Expand Down Expand Up @@ -221,21 +223,6 @@ export const ProjectHomePage = () => {
onChange={(e) => setName(e.target.value)}
/>
</Block>
<Block
title="Project Settings"
description={
<>
<ExternalLink link={DOC_URL.DORA}>DORA metrics</ExternalLink>
<span style={{ marginLeft: 4 }}>
are four widely-adopted metrics for measuring software delivery performance.
</span>
</>
}
>
<Checkbox checked={enableDora} onChange={(e) => setEnableDora(e.target.checked)}>
Enable DORA Metrics
</Checkbox>
</Block>
</Modal>
{ready && dataSource.length === 1 && (
<OnboardTour nameRef={nameRef} connectionRef={connectionRef} configRef={configRef} />
Expand Down