Skip to content

fix(migration): fix unexpected defer unlock #7634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klesh merged 1 commit into from
Jun 19, 2024
Merged

fix(migration): fix unexpected defer unlock #7634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion backend/server/services/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,12 @@ var statusLock sync.Mutex
// This might be called concurrently across multiple API requests
func ExecuteMigration() errors.Error {
statusLock.Lock()
defer statusLock.Unlock()
if serviceStatus == SERVICE_STATUS_MIGRATING {
statusLock.Unlock()
return errors.BadInput.New("already migrating")
}
if serviceStatus == SERVICE_STATUS_READY {
statusLock.Unlock()
return nil
}
serviceStatus = SERVICE_STATUS_MIGRATING
Expand All @@ -146,6 +147,7 @@ func ExecuteMigration() errors.Error {
pipelineServiceInit()
statusLock.Lock()
serviceStatus = SERVICE_STATUS_READY
statusLock.Unlock()
return nil
}

Expand Down