fix: engineering overview dashboard#7717
Merged
Merged
Conversation
abeizn
approved these changes
Jul 11, 2024
Startrekzky
added a commit
to merico-ai/lake
that referenced
this pull request
Jul 11, 2024
* fix: engineering overview dashboard * fix: dynamically change the panel title value * fix: the time range filter of critical defects --------- Co-authored-by: Startrekzky <kaiyun.zhang@merico.dev>
Startrekzky
added a commit
that referenced
this pull request
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
fix the default value of this filter. It should be an empty string


fix the date range error.
between STR_TO_DATE('$month','%Y-%m-%d') and STR_TO_DATE('$month','%Y-%m-%d') + INTERVAL 1 MONTH - INTERVAL 1 DAY;between STR_TO_DATE('$month','%Y-%m-%d') and STR_TO_DATE('$month','%Y-%m-%d') + INTERVAL 1 MONTH;Honor the selected month filter in the two charts to make them consistent with the rest of charts


Dynamically change the panel title based on the selected month

Add the

meanvalue to the legend of all time-series paneloptimize SQLs of other panels
Screenshots