fix: addition of some commits are ridiculous huge#7719
Merged
Conversation
dosubot
Bot
added
size:M
abeizn
approved these changes
Jul 11, 2024
Contributor
|
🤖 Target: #release-v1.0 cherry pick finished successfully 🎉! |
github-actions
Bot
added
the
bot/auto-cherry-pick-completed
abeizn
pushed a commit
that referenced
this pull request
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Previously, I fixed #7426 with #7458 which seemed to be working just fine, but it turned out to be NOT true, it merely push the problem upstream without actually fixing anything.
The problem: when doing a shallow clone, commits are truncated at some point, which means there are some commits that have parents that do not exist in the cloned local repo, thus a huge
additionif we calculate the stat for those commits because they are compared against nothing.PR #7458 deepened the commit history by 1 step solving the stat of the newly added commits, but it failed to skip those parent commits and overwrite the correct values in the database.
The PR finished the leftover job.
How to apply
This is quite a severe bug that affects almost every single user.
Please upgrade to a fixed version and then do a Full Refresh for your projects to fix the incorrect LOC values.