refactor: CollectAccounts now uses simple ApiCollector#8067
Merged
Conversation
dosubot
Bot
added
size:S
sstojak1
added a commit
to sstojak1/incubator-devlake
that referenced
this pull request
Oct 25, 2024
Co-authored-by: Josip Stojak <Josip.Stojak@infobip.com>
klesh
pushed a commit
that referenced
this pull request
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
What does this PR do?
CollectAccounts is now using the simple ApiCollector.
Does this close any open issues?
Closes 8066
Screenshots
Include any relevant screenshots here.
Other Information
Any other information that is important to this PR.
You can test this by creating a new Devlake Project that will scrape data from SonarQube.
What you should notice is that there won't be duplicate date in
_raw_sonarqube_api_accountstable after each pipeline run.