Skip to content

feat: improve performance of the listing-scope-config-projects-and-scopes#8104

Merged
abeizn merged 2 commits into
mainfrom
fix-ls-sc-projects
Sep 25, 2024
Merged

feat: improve performance of the listing-scope-config-projects-and-scopes#8104
abeizn merged 2 commits into
mainfrom
fix-ls-sc-projects

Conversation

@klesh
Copy link
Copy Markdown
Contributor

@klesh klesh commented Sep 25, 2024

Summary

Problem:
The current implementation of the API for listing projects and scopes related to a specific Scope Config may experience timeouts, especially when hundreds of scopes are associated with the same Scope Config.

Solution:
This PR addresses the issue by optimizing the database query, reducing it to a single query to improve response time.

Screenshots

PixPin_2024-09-25_15-33-44

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. component/framework This issue or PR relates to the framework pr-type/feature-development This PR is to develop a new feature labels Sep 25, 2024
Copy link
Copy Markdown
Contributor

@abeizn abeizn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Sep 25, 2024
@abeizn abeizn merged commit 323b98e into main Sep 25, 2024
@abeizn abeizn deleted the fix-ls-sc-projects branch September 25, 2024 08:14
github-actions Bot pushed a commit that referenced this pull request Sep 25, 2024
…opes (#8104)

* feat: improve performance of the listing-scope-config-projects-and-scopes

* fix: linting
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions Bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Sep 25, 2024
abeizn pushed a commit that referenced this pull request Sep 25, 2024
…opes (#8104) (#8105)

* feat: improve performance of the listing-scope-config-projects-and-scopes

* fix: linting

Co-authored-by: Klesh Wong <zhenmian.huang@merico.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot/auto-cherry-pick-completed auto cherry pick completed component/framework This issue or PR relates to the framework lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/feature-development This PR is to develop a new feature size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants