Skip to content

fix: update change lead time details dashboard#8179

Merged
d4x1 merged 1 commit into
apache:mainfrom
merico-ai:fix-lead-time-details
Nov 1, 2024
Merged

fix: update change lead time details dashboard#8179
d4x1 merged 1 commit into
apache:mainfrom
merico-ai:fix-lead-time-details

Conversation

@Startrekzky
Copy link
Copy Markdown
Contributor

@Startrekzky Startrekzky commented Nov 1, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

  1. Fix the time filter, so that when the time range is within 1 month, the dashboard also shows the stats.
  2. Fix the key to filter PR from pr_created_date to pr_deployed_date to make it consistent with the condition of the pr table below.
  3. Update the dashboard intro.

Screenshots

image

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 1, 2024
@Startrekzky Startrekzky requested a review from klesh November 1, 2024 10:15
@dosubot dosubot Bot added component/ext This issue or PR relates to external components, such as Grafana needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug severity/p2 This bug doesn’t affect the functionality or isn’t evident labels Nov 1, 2024
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Nov 1, 2024
@d4x1 d4x1 merged commit 5cd96a1 into apache:main Nov 1, 2024
@Startrekzky Startrekzky deleted the fix-lead-time-details branch November 1, 2024 11:03
Startrekzky added a commit to merico-ai/lake that referenced this pull request Nov 1, 2024
@Startrekzky @merico-devlake
fix: update change lead time details dashboard (apache#8179)
a62988b
@Startrekzky Startrekzky mentioned this pull request Nov 1, 2024
Merged
4 tasks
klesh pushed a commit that referenced this pull request Nov 1, 2024
@Startrekzky @merico-devlake
cherry-pick #8114 #8179 Fix DORA and lead time for changes details da…
83ec4a5 
…shboards (#8180)

* fix: improve the time filters in DORA dashboards (#8114)

Co-authored-by: Startrekzky <kaiyun.zhang@merico.dev>

* fix: update change lead time details dashboard (#8179)

---------

Co-authored-by: Startrekzky <kaiyun.zhang@merico.dev>
@klesh klesh mentioned this pull request Nov 20, 2024
Merged
@kostas-petrakis kostas-petrakis mentioned this pull request Feb 26, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4x1 d4x1 d4x1 approved these changes

@klesh klesh Awaiting requested review from klesh

Assignees

No one assigned

Labels

component/ext This issue or PR relates to external components, such as Grafana lgtm This PR has been approved by a maintainer needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug severity/p2 This bug doesn’t affect the functionality or isn’t evident size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Startrekzky @d4x1 @merico-devlake