Skip to content

fix(zentao): make sure connection uncacheable#8245

Merged
klesh merged 6 commits into
mainfrom
fix-1218-2
Dec 18, 2024
Merged

fix(zentao): make sure connection uncacheable#8245
klesh merged 6 commits into
mainfrom
fix-1218-2

Conversation

@d4x1
Copy link
Copy Markdown
Contributor

@d4x1 d4x1 commented Dec 18, 2024

⚠️ Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

  • I have read through the Contributing Documentation.
  • I have added relevant tests.
  • I have added relevant documentation.
  • I will add labels to the PR, such as pr-type/bug-fix, pr-type/feature-development, etc.

Summary

What does this PR do?
According to https://www.zentao.net/book/api/664.html#6, zentao's token will expire after 24 min. If users try to list scopes after 24 min, the api client will get a response with http status code 401.
This PR just makes sure zentao connections uncacheable.

Does this close any open issues?

Closes N/A

Screenshots

Include any relevant screenshots here.

Other Information

Any other information that is important to this PR.

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 18, 2024
@d4x1 d4x1 added the pr-type/bug-fix This PR fixes a bug label Dec 18, 2024
@dosubot dosubot Bot added the component/plugins This issue or PR relates to plugins label Dec 18, 2024
@klesh klesh merged commit bebd054 into main Dec 18, 2024
@klesh klesh deleted the fix-1218-2 branch December 18, 2024 07:51
github-actions Bot pushed a commit that referenced this pull request Dec 18, 2024
* fix(zentao): make sure connection uncacheable

* fix(zentao): fix lint errors

* Revert "fix(zentao): fix lint errors"

This reverts commit e216a23.

* fix(zentao): fix lint errors

* fix(zentao): remove UnCacheableConnetion interface, try to fix it with another way
@github-actions
Copy link
Copy Markdown
Contributor

🤖 Target: #release-v1.0 cherry pick finished successfully 🎉!

@github-actions github-actions Bot added the bot/auto-cherry-pick-completed auto cherry pick completed label Dec 18, 2024
d4x1 added a commit that referenced this pull request Dec 18, 2024
* fix(zentao): make sure connection uncacheable

* fix(zentao): fix lint errors

* Revert "fix(zentao): fix lint errors"

This reverts commit e216a23.

* fix(zentao): fix lint errors

* fix(zentao): remove UnCacheableConnetion interface, try to fix it with another way

Co-authored-by: Lynwee <1507509064@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot/auto-cherry-pick-completed auto cherry pick completed component/plugins This issue or PR relates to plugins needs-cherrypick-v1.0 pr-type/bug-fix This PR fixes a bug size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants