Skip to content

feat: starrocsk plugin add table config #8268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
klesh merged 1 commit into from
Jan 16, 2025
Merged

feat: starrocsk plugin add table config #8268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions backend/plugins/starrocks/tasks/task_data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ limitations under the License.

package tasks

type TableConfig struct {
IncludedColumns []string `mapstructure:"included_columns"`
ExcludedColumns []string `mapstructure:"excluded_columns"`
}

type StarRocksConfig struct {
SourceType string `mapstructure:"source_type"`
SourceDsn string `mapstructure:"source_dsn"`
Expand All @@ -29,8 +34,9 @@ type StarRocksConfig struct {
BeHost string `mapstructure:"be_host"`
BePort int `mapstructure:"be_port"`
Tables []string
BatchSize int `mapstructure:"batch_size"`
OrderBy map[string]string `mapstructure:"order_by"`
DomainLayer string `mapstructure:"domain_layer"`
TableConfigs map[string]TableConfig `mapstructure:"table_configs"`
BatchSize int `mapstructure:"batch_size"`
OrderBy map[string]string `mapstructure:"order_by"`
DomainLayer string `mapstructure:"domain_layer"`
Extra map[string]string
}
17 changes: 15 additions & 2 deletions backend/plugins/starrocks/tasks/tasks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ import (
"strings"
"time"

"golang.org/x/exp/slices"

"github.com/apache/incubator-devlake/core/dal"
"github.com/apache/incubator-devlake/core/errors"
"github.com/apache/incubator-devlake/core/plugin"
Expand Down Expand Up @@ -138,7 +140,6 @@ func createTmpTableInStarrocks(dc *DataConfigParams) (map[string]string, string,
table := dc.SrcTableName
starrocksTable := dc.DestTableName
starrocksTmpTable := fmt.Sprintf("%s_tmp", starrocksTable)

columnMetas, err := db.GetColumns(&Table{name: table}, nil)
updateColumn := config.UpdateColumn
columnMap := make(map[string]string)
Expand All @@ -163,8 +164,21 @@ func createTmpTableInStarrocks(dc *DataConfigParams) (map[string]string, string,
} else {
return nil, "", false, errors.NotFound.New(fmt.Sprintf("unsupported dialect %s", db.Dialect()))
}
tableConfig, ok := config.TableConfigs[table]
for _, cm := range columnMetas {
name := cm.Name()
if ok {
if len(tableConfig.ExcludedColumns) > 0 {
if slices.Contains(tableConfig.ExcludedColumns, name) {
continue
}
}
if len(tableConfig.IncludedColumns) > 0 {
if !slices.Contains(tableConfig.IncludedColumns, name) {
continue
}
}
}
if name == updateColumn {
// check update column to detect skip or not
var updatedFrom time.Time
Expand Down Expand Up @@ -276,7 +290,6 @@ func copyDataToDst(dc *DataConfigParams, columnMap map[string]string, orderBy st
} else {
return err
}

}
defer rows.Close()

Expand Down