Skip to content

feat: support Zentao task worklogs#8298

Merged
d4x1 merged 6 commits into
apache:mainfrom
usharerose:feat-zentao-issue-worklogs
Feb 21, 2025
Merged

feat: support Zentao task worklogs#8298
d4x1 merged 6 commits into
apache:mainfrom
usharerose:feat-zentao-issue-worklogs

Conversation

@usharerose
Copy link
Copy Markdown
Contributor

@usharerose usharerose commented Feb 20, 2025

Summary

make plugin zentao support worklogs

Does this close any open issues?

N/A

Screenshots

  • Domain Layer
Screenshot 2025-02-21 at 09 37 24
  • Tool Layer
Screenshot 2025-02-21 at 09 38 12
  • Raw Layer
Screenshot 2025-02-21 at 09 39 30

Other Information

N/A

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 20, 2025
@usharerose usharerose marked this pull request as draft February 20, 2025 09:04
@dosubot dosubot Bot added component/plugins This issue or PR relates to plugins pr-type/feature-development This PR is to develop a new feature labels Feb 20, 2025
@usharerose usharerose marked this pull request as ready for review February 21, 2025 01:40
ApiClient: data.ApiClient,
UrlTemplate: "tasks/{{ .Input.Id }}/estimate",
Query: func(reqData *api.RequestData) (url.Values, errors.Error) {
// According to the following resources, the worklogs API returns all worklogs without pagination
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these comments outdated?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Has been corrected.

@d4x1
Copy link
Copy Markdown
Contributor

d4x1 commented Feb 21, 2025

Please add a e2e test for the new tasks. @usharerose

@dosubot dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Feb 21, 2025
@d4x1 d4x1 merged commit b64a293 into apache:main Feb 21, 2025
d4x1 added a commit that referenced this pull request Feb 21, 2025
* feat: support Zentao task worklogs

* feat: Zentao worklog tool layer migration

* fix: dict as raw data instead of slice

* test: e2e for zentao task worklogs

* fix: compatibility when no account available

---------

Co-authored-by: Lynwee <1507509064@qq.com>
d4x1 added a commit that referenced this pull request Feb 21, 2025
* feat: support Zentao task worklogs (#8298)

* feat: support Zentao task worklogs

* feat: Zentao worklog tool layer migration

* fix: dict as raw data instead of slice

* test: e2e for zentao task worklogs

* fix: compatibility when no account available

---------

Co-authored-by: Lynwee <1507509064@qq.com>

* fix: go lint and import errors (#8300)

* fix: import errors

* fix: go fmt issues

* fix: missing quote

* fix: skip float accuracy issues

* fix(zentao): fix e2e tests

---------

Co-authored-by: Chaojie Yan <chaojie.yan@merico.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/plugins This issue or PR relates to plugins needs-cherrypick-v1.0 pr-type/feature-development This PR is to develop a new feature size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants